Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: chrome/browser/resources/history/history.js

Issue 591353002: history: fix focus regression when showing "Remove history" confirmation dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/history/history.js
diff --git a/chrome/browser/resources/history/history.js b/chrome/browser/resources/history/history.js
index 0f285966adf808ef26d31ec336be8e2068b9b8bc..d57b119d8ba83da4edd8d730ed397f44bc883328 100644
--- a/chrome/browser/resources/history/history.js
+++ b/chrome/browser/resources/history/history.js
@@ -1975,6 +1975,7 @@ function openClearBrowsingData(e) {
function showConfirmationOverlay() {
$('alertOverlay').classList.add('showing');
$('overlay').hidden = false;
+ $('alertOverlayCancel').focus();
Dan Beam 2014/09/23 05:17:37 btw, the buttons are reversed ("Remove" is the can
Evan Stade 2014/09/23 20:48:52 I don't think that this restores the previous beha
Dan Beam 2014/09/23 20:50:22 i think this is better than the previous behavior
Dan Beam 2014/09/23 20:59:38 we looked at this together and it's not quite the
uber.invokeMethodOnParent('beginInterceptingEvents');
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698