history: fix focus regression when showing "Remove history" confirmation dialog.

chrome/browser/resources/history/history.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../uber/uber_utils.js">
 <include src="history_focus_manager.js">
 
 ///////////////////////////////////////////////////////////////////////////////
 // Globals:
 /** @const */ var RESULTS_PER_PAGE = 150;
@@ skipping 1957 matching lines @@
   recordUmaAction('HistoryPage_InitClearBrowsingData');
   chrome.send('clearBrowsingData');
 }
 
 /**
  * Shows the dialog for the user to confirm removal of selected history entries.
  */
 function showConfirmationOverlay() {
   $('alertOverlay').classList.add('showing');
   $('overlay').hidden = false;
+  $('alertOverlayCancel').focus();

[Dan Beam, 2014/09/23 05:17:37]

btw, the buttons are reversed ("Remove" is the cancel button and "Cancel" is the
ok button).

[Evan Stade, 2014/09/23 20:48:52]

I don't think that this restores the previous behavior, because before you had
to press tab to get focus on the remove button.

Also, I don't think this regression is impactful enough to warrant a merge.

[Dan Beam, 2014/09/23 20:50:22]

i think this is better than the previous behavior as it's what all settings
dialogs do
that's fine by me

[Dan Beam, 2014/09/23 20:59:38]

we looked at this together and it's not quite the same.  fixing this dialog to:
- handle enter
- focus on first tab

   uber.invokeMethodOnParent('beginInterceptingEvents');
 }
 
 /**
  * Hides the confirmation overlay used to confirm selected history entries.
  */
 function hideConfirmationOverlay() {
   $('alertOverlay').classList.remove('showing');
   $('overlay').hidden = true;
   uber.invokeMethodOnParent('stopInterceptingEvents');
@@ skipping 278 matching lines @@
     historyView.reload();
 }
 
 // Add handlers to HTML elements.
 document.addEventListener('DOMContentLoaded', load);
 
 // This event lets us enable and disable menu items before the menu is shown.
 document.addEventListener('canExecute', function(e) {
   e.canExecute = true;
 });