Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 59133009: Properly support UNC paths in pkg/path. (Closed)

Created:
7 years, 1 month ago by nweiz
Modified:
7 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Properly support UNC paths in pkg/path. This treats the entire "\\server\share" component as the root. R=rnystrom@google.com BUG=7323 Committed: https://code.google.com/p/dart/source/detail?r=30257

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -43 lines) Patch
M pkg/path/lib/path.dart View 2 chunks +10 lines, -11 lines 0 comments Download
M pkg/path/test/windows_test.dart View 15 chunks +34 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 1 month ago (2013-11-13 22:25:24 UTC) #1
Bob Nystrom
LGTM!
7 years, 1 month ago (2013-11-13 22:57:40 UTC) #2
nweiz
7 years, 1 month ago (2013-11-13 23:00:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30257 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698