Issue 59133003: Add back assertion SetResourceConstraints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59133003: Add back assertion SetResourceConstraints. (Closed)

Created:
7 years, 1 month ago by rmcilroy

Modified:
7 years, 1 month ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Add back assertion SetResourceConstraints. This reverts commit f7f04272208d565020b528145ce6cef0f89c7079. BUG=312233 R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17493

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	src/api.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

rmcilroy

Adding back assert now that issue is fixed in Chrome. PTAL

7 years, 1 month ago (2013-11-05 13:35:40 UTC) #1

Sven Panne

LGTM, I'll land it for you. Nit: The SHA1 in the comment doesn't help, because ...

7 years, 1 month ago (2013-11-05 14:21:26 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r17493.