Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 591313004: Reusing base::StringPairs in src/extentions/ (Closed)

Created:
6 years, 3 months ago by ARUNKK
Modified:
6 years, 3 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reusing base::StringPairs in src/extentions/ Reusing the "base::StringPairs" insted of "std::vector<std::pair<std::string, std::string> >" same is defined in base/strings/string_split.h. BUG=412250 Committed: https://crrev.com/9d13b52bb61f2bf496fac4caf76f43e5c02c6a3c Cr-Commit-Position: refs/heads/master@{#296192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M extensions/common/permissions/permission_message_util.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ARUNKK
PTAL
6 years, 3 months ago (2014-09-23 12:55:49 UTC) #2
Finnur
LGTM
6 years, 3 months ago (2014-09-23 14:27:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591313004/1
6 years, 3 months ago (2014-09-23 14:49:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 701b3d6ee3aedabc7ae3654d74abfd34be3b49ff
6 years, 3 months ago (2014-09-23 15:36:32 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 15:37:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d13b52bb61f2bf496fac4caf76f43e5c02c6a3c
Cr-Commit-Position: refs/heads/master@{#296192}

Powered by Google App Engine
This is Rietveld 408576698