Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 591313002: mac: Fix spellcheck test on OSX 10.10. (Closed)

Created:
6 years, 3 months ago by erikchen
Modified:
6 years, 3 months ago
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spellwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mac: Fix spellcheck test on OSX 10.10. The OSX 10.10 dictionary changed its suggested corrections to "bouy", which used to include "buoy". I updated the test to check that "bouy" has the suggested correction "bout", which is present in the dictionary for both OSX 10.9 and OSX 10.10. BUG=390276 Committed: https://crrev.com/2637bf5431c284d673ba1ea73ee8f2623723a2a8 Cr-Commit-Position: refs/heads/master@{#296626}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Change bout -> body to accomodate 10.6 dictionary. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
erikchen
avi: Please review.
6 years, 3 months ago (2014-09-23 22:33:48 UTC) #2
Avi (use Gerrit)
https://codereview.chromium.org/591313002/diff/1/chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc File chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc (right): https://codereview.chromium.org/591313002/diff/1/chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc#newcode142 chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc:142: {"bouy", "bout"}, How far back does "bout" work? I'd ...
6 years, 3 months ago (2014-09-23 23:15:09 UTC) #3
groby-ooo-7-16
https://codereview.chromium.org/591313002/diff/1/chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc File chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc (right): https://codereview.chromium.org/591313002/diff/1/chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc#newcode142 chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc:142: {"bouy", "bout"}, On 2014/09/23 23:15:09, Avi wrote: > How ...
6 years, 3 months ago (2014-09-23 23:17:32 UTC) #4
erikchen
https://codereview.chromium.org/591313002/diff/1/chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc File chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc (right): https://codereview.chromium.org/591313002/diff/1/chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc#newcode142 chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc:142: {"bouy", "bout"}, On 2014/09/23 23:15:09, Avi wrote: > How ...
6 years, 3 months ago (2014-09-23 23:28:20 UTC) #5
Avi (use Gerrit)
I didn't catch the fact that there are already comments in this word list. LGTM ...
6 years, 3 months ago (2014-09-23 23:40:02 UTC) #6
erikchen
groby: Looking for an OWNER review. I've manually tested the new version of the test ...
6 years, 3 months ago (2014-09-25 00:09:13 UTC) #9
groby-ooo-7-16
LGTM - although I still think you could've just killed that :)
6 years, 3 months ago (2014-09-25 00:17:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591313002/40001
6 years, 3 months ago (2014-09-25 00:20:28 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001) as b65f6170b47348fc01004ab84992bf941dd51962
6 years, 3 months ago (2014-09-25 02:11:52 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-25 02:13:09 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2637bf5431c284d673ba1ea73ee8f2623723a2a8
Cr-Commit-Position: refs/heads/master@{#296626}

Powered by Google App Engine
This is Rietveld 408576698