Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 591293002: DrMemory: Disable ApplicationManagerTest and ViewManagerTest. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, glider+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, timurrrr+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DrMemory: Disable ApplicationManagerTest and ViewManagerTest. Multiple tests cases in these tests fail. Mass disabling rather than playing whack-a-mole. BUG=416620, 416621 TBR=davemoore@chromium.org NOTRY=true Committed: https://crrev.com/0fb0a60d20f1cf75043db3f73726d7d2b82abe9a Cr-Commit-Position: refs/heads/master@{#296110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/valgrind/gtest_exclude/mojo_application_manager_unittests.gtest-drmemory.txt View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/gtest_exclude/mojo_view_manager_unittests.gtest-drmemory.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Lei Zhang
TBR x2
6 years, 3 months ago (2014-09-23 00:44:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591293002/1
6 years, 3 months ago (2014-09-23 00:46:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as f64c5483de55e8e1e7fe2872cedea539244d3e2d
6 years, 3 months ago (2014-09-23 00:47:00 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 00:47:36 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fb0a60d20f1cf75043db3f73726d7d2b82abe9a
Cr-Commit-Position: refs/heads/master@{#296110}

Powered by Google App Engine
This is Rietveld 408576698