Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1620)

Issue 591283002: [proguard] Add VisibleToTesting to clearHistory on NavigationController. (Closed)

Created:
6 years, 3 months ago by Ted C
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[proguard] Add VisibleToTesting to clearHistory on NavigationController. Only used in tests currently, so we need to prevent it from being removed. BUG= NOTRY=true Committed: https://crrev.com/11383c4feb2c81c916c7d01d1c636fa698daeb1b Cr-Commit-Position: refs/heads/master@{#296103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content_public/browser/NavigationController.java View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ted C
PTAL
6 years, 3 months ago (2014-09-22 23:58:18 UTC) #2
aurimas (slooooooooow)
lgtm
6 years, 3 months ago (2014-09-22 23:59:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591283002/1
6 years, 3 months ago (2014-09-23 00:13:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 693c8e2dbc78b6c8a8e76ab649bed133a794657b
6 years, 3 months ago (2014-09-23 00:14:09 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 00:14:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11383c4feb2c81c916c7d01d1c636fa698daeb1b
Cr-Commit-Position: refs/heads/master@{#296103}

Powered by Google App Engine
This is Rietveld 408576698