[Win] Allow using the arrow keys for tabbing in the avatar bubble.

[Win] Allow using the arrow keys for tabbing in the avatar bubble.

BUG=414794
Committed: https://crrev.com/bca647762d3eeede9e2362d3dd75b0fa574f8ce9
Cr-Commit-Position: refs/heads/master@{#296189}

[noms (inactive), 2014-09-22 21:39:40]

noms@chromium.org changed reviewers:
+ pkasting@chromium.org

[noms (inactive), 2014-09-22 21:39:40]

Hi Peter,

We've decided to allow users to use up/down arrows to tab between items because
that's what they're used to from the old avatar bubble. Please take a look!

[Peter Kasting, 2014-09-22 23:52:18]

LGTM

https://codereview.chromium.org/591263002/diff/1/chrome/browser/ui/views/prof...
File chrome/browser/ui/views/profiles/profile_chooser_view.h (right):

https://codereview.chromium.org/591263002/diff/1/chrome/browser/ui/views/prof...
chrome/browser/ui/views/profiles/profile_chooser_view.h:107: // views::View:
Nit: We don't subclass View directly, so don't create a section for it. 
Instead, put this override in the correct relative order within the section for
the descendent of View (BubbleDelegateView, I think).

[Peter Kasting, 2014-09-22 23:52:33]

Forgot.  We should probably add a test for these keys.

[noms (inactive), 2014-09-23 14:19:14]

We have some browser tests that the ProfileChooser starts up, and for locking,
but we don't have any Windows unit tests that check the layout. I think that is
out of the scope of this CL.

https://codereview.chromium.org/591263002/diff/1/chrome/browser/ui/views/prof...
File chrome/browser/ui/views/profiles/profile_chooser_view.h (right):

https://codereview.chromium.org/591263002/diff/1/chrome/browser/ui/views/prof...
chrome/browser/ui/views/profiles/profile_chooser_view.h:107: // views::View:
On 2014/09/22 23:52:17, Peter Kasting wrote:
> Nit: We don't subclass View directly, so don't create a section for it. 
> Instead, put this override in the correct relative order within the section
for
> the descendent of View (BubbleDelegateView, I think).

Done.

[noms (inactive), 2014-09-23 14:19:27]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-09-23 14:27:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/591263002/20001

[commit-bot: I haz the power, 2014-09-23 14:27:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/591263002/20001

[commit-bot: I haz the power, 2014-09-23 15:28:36]

Committed patchset #2 (id:20001) as 525c7ddd8b5de7eec329557956d21c99a6dab227

[commit-bot: I haz the power, 2014-09-23 15:29:42]

Patchset 2 (id:??) landed as
https://crrev.com/bca647762d3eeede9e2362d3dd75b0fa574f8ce9
Cr-Commit-Position: refs/heads/master@{#296189}

[Peter Kasting, 2014-09-23 18:26:06]

On 2014/09/23 14:19:14, Monica Dinculescu wrote:
> We have some browser tests that the ProfileChooser starts up, and for locking,
> but we don't have any Windows unit tests that check the layout. I think that
is
> out of the scope of this CL.

I'm not talking about checking layout in detail, I'm simply talking about
opening the window, hitting arrow keys, and verifying that the selected child is
correct (or at least different).  This would be an interactive UI test, not a
unit test.

I don't think that's out of scope here.  Please implement some kind of test.