Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issue 591253002: Fix image capture crash on ICS (Closed)

Created:
6 years, 3 months ago by qinmin
Modified:
6 years, 3 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix image capture crash on ICS camera.setClipData() is not supported on ICS. And without that call, we cannot use a temp file path under chrome directory. Reverted the logic on ICS to use external Camera directory to store captured images. BUG=416516 Committed: https://crrev.com/714451260d90aca7e901ed5f3f417491496ac87a Cr-Commit-Position: refs/heads/master@{#296064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java View 3 chunks +33 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
qinmin
PTAL
6 years, 3 months ago (2014-09-22 21:01:06 UTC) #2
Ted C
lgtm
6 years, 3 months ago (2014-09-22 21:04:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591253002/1
6 years, 3 months ago (2014-09-22 21:11:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as d868fe62bc520c920c908e774e30d503e8e51eea
6 years, 3 months ago (2014-09-22 22:08:54 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 22:09:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/714451260d90aca7e901ed5f3f417491496ac87a
Cr-Commit-Position: refs/heads/master@{#296064}

Powered by Google App Engine
This is Rietveld 408576698