Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 591243003: Add ctrl+mousewheel plumbing to MimeHandlerView. (Closed)

Created:
6 years, 3 months ago by lazyboy
Modified:
6 years, 3 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@work-pdf-zoom1
Project:
chromium
Visibility:
Public.

Description

Add ctrl+mousewheel plumbing to MimeHandlerView. This will zoom in/out the view properly. This CL is dependant on http://crrev.com/597653002 BUG=416332 Test=Load chrome with --enable-mime-handler-view and --out-of-process-pdf Navigate to a pdf file, Ctrl + wheel up and down should zoom in/out the pdf properly. Committed: https://crrev.com/8e78ec069ee92035c1a82817527dd81f448253a1 Cr-Commit-Position: refs/heads/master@{#296455}

Patch Set 1 #

Total comments: 3

Messages

Total messages: 9 (2 generated)
lazyboy
6 years, 3 months ago (2014-09-23 18:38:50 UTC) #2
Fady Samuel
https://chromiumcodereview.appspot.com/591243003/diff/1/chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc File chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc (right): https://chromiumcodereview.appspot.com/591243003/diff/1/chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc#newcode50 chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc:50: guest_->embedder_web_contents(), Wow, this is a bit weird. We're telling ...
6 years, 3 months ago (2014-09-23 18:52:12 UTC) #3
lazyboy
https://chromiumcodereview.appspot.com/591243003/diff/1/chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc File chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc (right): https://chromiumcodereview.appspot.com/591243003/diff/1/chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc#newcode50 chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc:50: guest_->embedder_web_contents(), On 2014/09/23 18:52:12, Fady Samuel wrote: > Wow, ...
6 years, 3 months ago (2014-09-24 16:26:49 UTC) #4
Fady Samuel
https://chromiumcodereview.appspot.com/591243003/diff/1/chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc File chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc (right): https://chromiumcodereview.appspot.com/591243003/diff/1/chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc#newcode50 chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc:50: guest_->embedder_web_contents(), On 2014/09/24 16:26:49, lazyboy wrote: > On 2014/09/23 ...
6 years, 3 months ago (2014-09-24 16:32:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591243003/1
6 years, 3 months ago (2014-09-24 16:49:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as b7215415aec68c4b8fbe52d7b3e2a4cdc25b5f8f
6 years, 3 months ago (2014-09-24 17:53:01 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 17:53:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e78ec069ee92035c1a82817527dd81f448253a1
Cr-Commit-Position: refs/heads/master@{#296455}

Powered by Google App Engine
This is Rietveld 408576698