Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 591163002: Revert of Swarming configuration files for chromoting integration tests (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Swarming configuration files for chromoting integration tests (patchset #4 id:60001 of https://codereview.chromium.org/498373003/) Reason for revert: This is slowing down the trybots because it's uploading these files even though they're not used on trybots. look at how gpu isolates that are only used on the GPU builders are handled (there's a gyp variable which is only set by the builders which run these tests) Original issue's description: > Swarming configuration files for chromoting integration tests. > > BUG= > > Committed: https://crrev.com/d90ba4c4e4ddf5c4cbb6cf812c9571d628e30567 > Cr-Commit-Position: refs/heads/master@{#292785} TBR=maruel@chromium.org,anandc@chromium.org,chaitali@chromium.org,anandc@google.com,leilei@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/b2c1542b0239e06c2dcc764af156054b5d5b8680 Cr-Commit-Position: refs/heads/master@{#295980}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -97 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -7 lines 0 comments Download
D testing/chromoting/chromoting_integration_tests.isolate View 1 chunk +0 lines, -63 lines 0 comments Download
D testing/chromoting/integration_test.gyp View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Created Revert of Swarming configuration files for chromoting integration tests
6 years, 3 months ago (2014-09-22 16:06:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591163002/1
6 years, 3 months ago (2014-09-22 16:08:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as a823af5b12693dd0ea208d44197f79d9c29227cc
6 years, 3 months ago (2014-09-22 16:09:28 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 16:10:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2c1542b0239e06c2dcc764af156054b5d5b8680
Cr-Commit-Position: refs/heads/master@{#295980}

Powered by Google App Engine
This is Rietveld 408576698