Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 591153002: android_webview: Enable FDO support for some targets. (Closed)

Created:
6 years, 3 months ago by Torne
Modified:
6 years, 2 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, android-webview-reviews_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

android_webview: Enable FDO support for some targets. Enable feedback-directed optimisation for the main library (required to make the FDO symbols present at link time), skia, and sqlite. Update the android_exports whitelist to allow the gcov symbols to remain public as otherwise profiling will fail. BUG= TBR=michaeln@chromium.org Committed: https://crrev.com/c7f9a36cbad5fa14875e26d704ba89208f7cb40f Cr-Commit-Position: refs/heads/master@{#296997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M android_webview/libwebviewchromium.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M build/android/android_exports.lst View 1 chunk +2 lines, -1 line 0 comments Download
M skia/skia_common.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
Torne
This enables LOCAL_FDO_SUPPORT in the same targets where it was enabled downstream in commit b82e5f8, ...
6 years, 3 months ago (2014-09-22 16:08:37 UTC) #2
dehao
lgtm
6 years, 3 months ago (2014-09-22 16:40:24 UTC) #3
benm (inactive)
lgtm
6 years, 2 months ago (2014-09-23 18:43:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591153002/1
6 years, 2 months ago (2014-09-23 20:31:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/12915)
6 years, 2 months ago (2014-09-23 20:53:55 UTC) #8
benm (inactive)
+djsollen for skia owners +michaeln for sqlite owners
6 years, 2 months ago (2014-09-24 08:59:29 UTC) #10
Primiano Tucci (use gerrit)
lgtm
6 years, 2 months ago (2014-09-24 10:34:17 UTC) #11
djsollen
lgtm
6 years, 2 months ago (2014-09-24 13:48:14 UTC) #12
benm (inactive)
Michael, I hope you don't mind me TBRing you on this gypi change (we've tested ...
6 years, 2 months ago (2014-09-26 09:47:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591153002/1
6 years, 2 months ago (2014-09-26 09:48:41 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/16456)
6 years, 2 months ago (2014-09-26 17:11:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591153002/1
6 years, 2 months ago (2014-09-26 18:22:39 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1) as 99ffbe0864fa3f86aca837ea1fb949423bad4b43
6 years, 2 months ago (2014-09-26 19:05:15 UTC) #21
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 19:05:57 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7f9a36cbad5fa14875e26d704ba89208f7cb40f
Cr-Commit-Position: refs/heads/master@{#296997}

Powered by Google App Engine
This is Rietveld 408576698