chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc - Issue 59113012: Removed SpdyProxyAuth.State histogram

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

Issue 59113012: Removed SpdyProxyAuth.State histogram (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/spdyproxy/data_reduction_proxy_settings.h ('K') | « chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc b/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

index 73b0b05e877ce14098983aa382a047354ae242ce..95849b325b23a7b1df20aa7616e8062b4f15e258 100644

--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

@@ -92,14 +92,10 @@ TEST_F(DataReductionProxySettingsAndroidTest, TestSetProxyPac) {

base::Base64Encode(raw_pac, &pac);

std::string expected_pac_url =

"data:application/x-ns-proxy-autoconfig;base64," + pac;

- // Test setting the PAC, without generating histograms.

- Settings()->SetHasTurnedOn();

Settings()->SetProxyConfigs(true, false);

CheckProxyPacPref(expected_pac_url,

ProxyModeToString(ProxyPrefs::MODE_PAC_SCRIPT));

- // Test disabling the PAC, without generating histograms.

- Settings()->SetHasTurnedOff();

Settings()->SetProxyConfigs(false, false);

CheckProxyPacPref(std::string(), ProxyModeToString(ProxyPrefs::MODE_SYSTEM));

}