Removed SpdyProxyAuth.State histogram

Removed SpdyProxyAuth.State histogram

The change to UMA aligns metrics for the data reduction proxy on
Android and iOS.

BUG=241518
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233507

[marq (ping after 24h), 2013-11-06 18:52:14]

lgtm

[commit-bot: I haz the power, 2013-11-06 19:17:45]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bengr, 2013-11-06 19:19:21]

mmenke: marq isn't a full committer yet. PTAL.

[mmenke, 2013-11-06 19:24:02]

https://codereview.chromium.org/59113012/diff/1/chrome/browser/net/spdyproxy/...
File chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc
(left):

https://codereview.chromium.org/59113012/diff/1/chrome/browser/net/spdyproxy/...
chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc:259:
DataReductionProxySettings::SetHasTurnedOn();
If these methods aren't being used any more, they should be removed.

https://codereview.chromium.org/59113012/diff/1/chrome/browser/net/spdyproxy/...
File chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc
(right):

https://codereview.chromium.org/59113012/diff/1/chrome/browser/net/spdyproxy/...
chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc:27:
#include "content/public/browser/user_metrics.h"
This isn't used.

https://codereview.chromium.org/59113012/diff/1/chrome/browser/net/spdyproxy/...
chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc:45: using
content::UserMetricsAction;
These aren't used.

[bengr, 2013-11-06 19:44:11]

https://codereview.chromium.org/59113012/diff/1/chrome/browser/net/spdyproxy/...
File chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc
(left):

https://codereview.chromium.org/59113012/diff/1/chrome/browser/net/spdyproxy/...
chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc:259:
DataReductionProxySettings::SetHasTurnedOn();
On 2013/11/06 19:24:03, mmenke wrote:
> If these methods aren't being used any more, they should be removed.

Done.

https://codereview.chromium.org/59113012/diff/1/chrome/browser/net/spdyproxy/...
File chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc
(right):

https://codereview.chromium.org/59113012/diff/1/chrome/browser/net/spdyproxy/...
chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc:27:
#include "content/public/browser/user_metrics.h"
On 2013/11/06 19:24:03, mmenke wrote:
> This isn't used.

Done.

https://codereview.chromium.org/59113012/diff/1/chrome/browser/net/spdyproxy/...
chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc:45: using
content::UserMetricsAction;
On 2013/11/06 19:24:03, mmenke wrote:
> These aren't used.

Done.

[mmenke, 2013-11-06 19:48:34]

https://codereview.chromium.org/59113012/diff/90001/chrome/browser/net/spdypr...
File chrome/browser/net/spdyproxy/data_reduction_proxy_settings.h (right):

https://codereview.chromium.org/59113012/diff/90001/chrome/browser/net/spdypr...
chrome/browser/net/spdyproxy/data_reduction_proxy_settings.h:227: bool
has_turned_off_;
Get rid of these, too.

[bengr, 2013-11-06 21:15:23]

https://codereview.chromium.org/59113012/diff/90001/chrome/browser/net/spdypr...
File chrome/browser/net/spdyproxy/data_reduction_proxy_settings.h (right):

https://codereview.chromium.org/59113012/diff/90001/chrome/browser/net/spdypr...
chrome/browser/net/spdyproxy/data_reduction_proxy_settings.h:227: bool
has_turned_off_;
On 2013/11/06 19:48:34, mmenke wrote:
> Get rid of these, too.

Done.

[mmenke, 2013-11-06 21:36:40]

LGTM

https://codereview.chromium.org/59113012/diff/150001/chrome/browser/net/spdyp...
File chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc
(right):

https://codereview.chromium.org/59113012/diff/150001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc:241: 
optional:  May want to get rid of this blank line - blank lines are pretty
uncommon between two rows with different indentation.

[commit-bot: I haz the power, 2013-11-06 22:04:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bengr@chromium.org/59113012/150001

[commit-bot: I haz the power, 2013-11-07 06:38:43]

Change committed as 233507