Add a browser test to automatically run end-to-end Hangout Services test.

Add a browser test to automatically run end-to-end Hangout Services test.

NOTRY=true
BUG=291271
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233409

[Henrik Grunell, 2013-11-06 08:49:00]

https://codereview.chromium.org/59113003/diff/70001/chrome/browser/extensions...
File
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
(right):

https://codereview.chromium.org/59113003/diff/70001/chrome/browser/extensions...
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc:312:
ExtensionBrowserTest::SetUp();
Just checking: should it be ExtensionApiTest::SetUp()?

https://codereview.chromium.org/59113003/diff/70001/chrome/browser/extensions...
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc:316:
IN_PROC_BROWSER_TEST_F(HangoutServicesBrowserTest,
If the services test runs other than audio tests, maybe it should be in it's own
file?

[Jói, 2013-11-06 11:19:29]

https://codereview.chromium.org/59113003/diff/70001/chrome/browser/extensions...
File
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
(right):

https://codereview.chromium.org/59113003/diff/70001/chrome/browser/extensions...
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc:312:
ExtensionBrowserTest::SetUp();
On 2013/11/06 08:49:01, Henrik Grunell wrote:
> Just checking: should it be ExtensionApiTest::SetUp()?

Good catch, it should be <superclass>::SetUp(), so changed it to
AudioWaitingExtensionTest::SetUp().

https://codereview.chromium.org/59113003/diff/70001/chrome/browser/extensions...
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc:316:
IN_PROC_BROWSER_TEST_F(HangoutServicesBrowserTest,
On 2013/11/06 08:49:01, Henrik Grunell wrote:
> If the services test runs other than audio tests, maybe it should be in it's
own
> file?

I thought about that, but it doesn't really belong anywhere better. Since it
shares implementation with the WebrtcAudioPrivateTest, I figured I would leave
it here.

[Henrik Grunell, 2013-11-06 11:43:30]

LGTM

https://codereview.chromium.org/59113003/diff/70001/chrome/browser/extensions...
File
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
(right):

https://codereview.chromium.org/59113003/diff/70001/chrome/browser/extensions...
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc:316:
IN_PROC_BROWSER_TEST_F(HangoutServicesBrowserTest,
On 2013/11/06 11:19:29, Jói wrote:
> On 2013/11/06 08:49:01, Henrik Grunell wrote:
> > If the services test runs other than audio tests, maybe it should be in it's
> own
> > file?
> 
> I thought about that, but it doesn't really belong anywhere better. Since it
> shares implementation with the WebrtcAudioPrivateTest, I figured I would leave
> it here.

I'm fine with that.

[commit-bot: I haz the power, 2013-11-06 12:29:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/59113003/250001

[commit-bot: I haz the power, 2013-11-06 15:24:13]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-11-06 15:36:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/59113003/250001

[commit-bot: I haz the power, 2013-11-06 19:45:06]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[Jói, 2013-11-06 22:21:01]

On 2013/11/06 19:45:06, I haz the power (commit-bot) wrote:
> Retried try job too often on linux_aura for step(s) browser_tests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

Setting NOTRY=true as manual inspection of tryjobs shows that the failures are
completely unrelated.

[commit-bot: I haz the power, 2013-11-06 22:48:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/59113003/250001

[commit-bot: I haz the power, 2013-11-06 23:06:54]

Change committed as 233409