Source/web/WebRemoteFrameImpl.cpp - Issue 591053002: Support print preset options for pdf document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebRemoteFrameImpl.cpp

Issue 591053002: Support print preset options for pdf document (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: out-params should be by pointer Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebRemoteFrameImpl.cpp

diff --git a/Source/web/WebRemoteFrameImpl.cpp b/Source/web/WebRemoteFrameImpl.cpp

index ddd1552ed65134b927d39c4eb5d2d695ba96b064..488addc09cb051350958cebbea45c69cf2a294c6 100644

--- a/Source/web/WebRemoteFrameImpl.cpp

+++ b/Source/web/WebRemoteFrameImpl.cpp

@@ -677,10 +677,10 @@ bool WebRemoteFrameImpl::isPrintScalingDisabledForPlugin(const WebNode&)

return false;

}

-int WebRemoteFrameImpl::getPrintCopiesForPlugin(const WebNode&)

+bool WebRemoteFrameImpl::getPrintPresetOptionsForPlugin(const WebNode&, WebPrintPresetOptions*)

{

ASSERT_NOT_REACHED();

- return 1;

+ return false;

}

bool WebRemoteFrameImpl::hasCustomPageSizeStyle(int pageIndex)