Issue 59103009: Refactor VariationsSeedProcessor to add ProcessedStudy struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59103009: Refactor VariationsSeedProcessor to add ProcessedStudy struct. (Closed)

Created:
7 years, 1 month ago by Alexei Svitkine (slow)

Modified:
7 years, 1 month ago

Reviewers:
jwd

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Refactor VariationsSeedProcessor to add ProcessedStudy struct. This paves way for more changes to follow that will re-use the FilterAndValidateStudies logic, but will do different things with the resulting ProcessedStudy list (simulate the resulting field trials). BUG=315807 TEST=New unit test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233740

Patch Set 1 : #

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -21 lines)			Patch
M	components/variations.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	components/variations/processed_study.h	View		1 chunk	+34 lines, -0 lines	0 comments	Download
A	components/variations/processed_study.cc	View		1 chunk	+22 lines, -0 lines	0 comments	Download
M	components/variations/variations_seed_processor.h	View	1	5 chunks	+23 lines, -4 lines	0 comments	Download
M	components/variations/variations_seed_processor.cc	View	1	6 chunks	+36 lines, -10 lines	0 comments	Download
M	components/variations/variations_seed_processor_unittest.cc	View	1	8 chunks	+48 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jwd

Some lint errors on the new files (missing newlines at eof) LGTM

7 years, 1 month ago (2013-11-07 16:07:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/59103009/830001

7 years, 1 month ago (2013-11-07 22:29:59 UTC) #4

Message was sent while issue was closed.

Change committed as 233740

Expand Messages | Collapse Messages