Issue 59103005: Proper fix for the issue exposed by r17459

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59103005: Proper fix for the issue exposed by r17459 (Closed)

Created:
7 years, 1 month ago by Jakob Kummerow

Modified:
7 years, 1 month ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Proper fix for the issue exposed by r17459 This reverts r17462 and instead fixes StubCache::ComputeLoadNonexistent by replacing s/IsGlobalObject/IsJSGlobalObject/ there. R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17474

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -49 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/ic.cc	View		2 chunks	+8 lines, -12 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/objects.h	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/objects.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/stub-cache.h	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/stub-cache.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

7 years, 1 month ago (2013-11-05 11:01:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r17474 (presubmit successful).