Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 590993003: Extend JSBuiltinReducer to cover Math.max as well. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Extend JSBuiltinReducer to cover Math.max as well. R=svenpanne@chromium.org TEST=cctest/test-js-typed-lowering/BuiltinMathMax Committed: https://code.google.com/p/v8/source/detail?r=24135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -7 lines) Patch
M src/compiler/js-builtin-reducer.h View 1 chunk +5 lines, -3 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 3 chunks +50 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 3 months ago (2014-09-22 12:06:28 UTC) #1
Sven Panne
lgtm
6 years, 3 months ago (2014-09-22 13:55:54 UTC) #2
Michael Starzinger
6 years, 3 months ago (2014-09-23 08:17:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24135 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698