Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 590983002: Revert of Try #3 to fix the android layout tests crash in run-webkit-tests. (Closed)

Created:
6 years, 3 months ago by caseq
Modified:
6 years, 3 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Revert of Try #3 to fix the android layout tests crash in run-webkit-tests. (patchset #2 id:20001 of https://codereview.chromium.org/591563002/) Reason for revert: Reverting, since this broke mac bots: UnicodeEncodeError raised: 'ascii' codec can't encode characters in position 11332-11333: ordinal not in range(128) Original issue's description: > Try #3 to fix the android layout tests crash in run-webkit-tests. > > This patch forcibly reencodes to ASCII at a different layer, matching > where we're actually seeing the stack trace. This seems like an > overly broad solution, but may at least get us past the crash so I can > see where things might really be failing. > > This change also backs out the change in r182282, since it didn't seem > to help anything. > > TBR=peter@chromium.org > BUG=386343 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182358 TBR=peter@chromium.org,dpranke@chromium.org NOTREECHECKS=true NOTRY=true BUG=386343 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/port/android.py View 1 chunk +3 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
caseq
Created Revert of Try #3 to fix the android layout tests crash in run-webkit-tests.
6 years, 3 months ago (2014-09-22 06:32:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590983002/1
6 years, 3 months ago (2014-09-22 06:32:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 182387
6 years, 3 months ago (2014-09-22 06:32:39 UTC) #3
Dirk Pranke
6 years, 3 months ago (2014-09-22 16:34:21 UTC) #4
Message was sent while issue was closed.
On 2014/09/22 06:32:39, I haz the power (commit-bot) wrote:
> Committed patchset #1 (id:1) as 182387

lgtm.

Powered by Google App Engine
This is Rietveld 408576698