content/browser/renderer_host/input/web_input_event_util.cc - Issue 590953002: Support isKeyPad modifier flag in Chrome OS and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/web_input_event_util.cc

Issue 590953002: Support isKeyPad modifier flag in Chrome OS and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to HEAD Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/input/web_input_event_util.cc

diff --git a/content/browser/renderer_host/input/web_input_event_util.cc b/content/browser/renderer_host/input/web_input_event_util.cc

index bdbec745a52b4083f816a9d3b7aa86cc2c4e844e..485185dc9c8ab71c1bef9f516b2b70dbaee052a2 100644

--- a/content/browser/renderer_host/input/web_input_event_util.cc

+++ b/content/browser/renderer_host/input/web_input_event_util.cc

@@ -400,6 +400,8 @@ int EventFlagsToWebEventModifiers(int flags) {

modifiers |= blink::WebInputEvent::CapsLockOn;

if (flags & ui::EF_IS_REPEAT)

modifiers |= blink::WebInputEvent::IsAutoRepeat;

+ if (flags & ui::EF_NUMPAD_KEY)

+ modifiers |= blink::WebInputEvent::IsKeyPad;

jdduke (slow) 2014/09/24 21:03:44 Don't you want a corresponding inverse conversion

Seigo Nonaka 2014/09/25 03:57:47 Yes! Added inverse conversion. Thanks. On 2014/09

return modifiers;

}

« no previous file with comments | « no previous file | content/browser/renderer_host/web_input_event_aura_unittest.cc » ('j') | no next file with comments »