Support isKeyPad modifier flag in Chrome OS and Linux.

Support isKeyPad modifier flag in Chrome OS and Linux.

BUG=N/A
TEST=unit tests passed.
TEST=manually confirmed keypad key has isKeyPad modifier.

Committed: https://crrev.com/33d91ccdbeec689689d5ae16b907a4149d7ebff3
Cr-Commit-Position: refs/heads/master@{#296788}

[Seigo Nonaka, 2014-09-22 06:27:57]

nona@chromium.org changed reviewers:
+ ben@chromium.org

[Seigo Nonaka, 2014-09-22 06:27:58]

Hi Ben, could you take a look?

Please see the try bot result in patch set 1 if necessary, (the patch set 2 is
nit pick only)

Thank you.

[Ben Goodger (Google), 2014-09-24 17:28:21]

lgtm

[Seigo Nonaka, 2014-09-24 17:36:19]

Thanks!

[Seigo Nonaka, 2014-09-24 17:36:22]

The CQ bit was checked by nona@chromium.org

[commit-bot: I haz the power, 2014-09-24 17:37:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/590953002/20001

[commit-bot: I haz the power, 2014-09-24 17:41:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-24 17:41:44]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/60155)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Seigo Nonaka, 2014-09-24 20:19:37]

nona@chromium.org changed reviewers:
+ jdduke@chromium.org

[Seigo Nonaka, 2014-09-24 20:19:37]

Unfortunately the file was gone during code review.
I rebased to HEAD and now input/OWNER's review is necessary.

+jdduke@chromium.org for
content/browser/renderer_host/input/web_input_event_util.cc

Jard, please take a look.

Thank you.

[jdduke (slow), 2014-09-24 21:03:44]

https://codereview.chromium.org/590953002/diff/40001/content/browser/renderer...
File content/browser/renderer_host/input/web_input_event_util.cc (right):

https://codereview.chromium.org/590953002/diff/40001/content/browser/renderer...
content/browser/renderer_host/input/web_input_event_util.cc:404: modifiers |=
blink::WebInputEvent::IsKeyPad;
Don't you want a corresponding inverse conversion in
WebEventModifiersToEventFlags?

[Seigo Nonaka, 2014-09-25 03:57:48]

Thank you for your review! PTAL

https://codereview.chromium.org/590953002/diff/40001/content/browser/renderer...
File content/browser/renderer_host/input/web_input_event_util.cc (right):

https://codereview.chromium.org/590953002/diff/40001/content/browser/renderer...
content/browser/renderer_host/input/web_input_event_util.cc:404: modifiers |=
blink::WebInputEvent::IsKeyPad;
Yes! Added inverse conversion. Thanks.

On 2014/09/24 21:03:44, jdduke wrote:
> Don't you want a corresponding inverse conversion in
> WebEventModifiersToEventFlags?

[jdduke (slow), 2014-09-25 15:55:37]

https://codereview.chromium.org/590953002/diff/60001/content/browser/renderer...
File content/browser/renderer_host/input/web_input_event_util.cc (right):

https://codereview.chromium.org/590953002/diff/60001/content/browser/renderer...
content/browser/renderer_host/input/web_input_event_util.cc:431: if (flags &
blink::WebInputEvent::IsKeyPad)
Hmm, pretty sure this should be |modifiers| and not |flags| =/

[Seigo Nonaka, 2014-09-25 16:06:45]

https://codereview.chromium.org/590953002/diff/60001/content/browser/renderer...
File content/browser/renderer_host/input/web_input_event_util.cc (right):

https://codereview.chromium.org/590953002/diff/60001/content/browser/renderer...
content/browser/renderer_host/input/web_input_event_util.cc:431: if (flags &
blink::WebInputEvent::IsKeyPad)
On 2014/09/25 15:55:37, jdduke wrote:
> Hmm, pretty sure this should be |modifiers| and not |flags| =/

Ugh, I'm sorry for my mistake.

[jdduke (slow), 2014-09-25 16:32:46]

content/browser/renderer_host/input/web_input_event_util.cc lgtm.

[Seigo Nonaka, 2014-09-25 17:12:59]

The CQ bit was checked by nona@chromium.org

[commit-bot: I haz the power, 2014-09-25 17:13:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/590953002/80001

[commit-bot: I haz the power, 2014-09-25 20:49:26]

Committed patchset #5 (id:80001) as 94ba43a1587410e114745204a251a2e61b86be9e

[commit-bot: I haz the power, 2014-09-25 20:50:19]

Patchset 5 (id:??) landed as
https://crrev.com/33d91ccdbeec689689d5ae16b907a4149d7ebff3
Cr-Commit-Position: refs/heads/master@{#296788}