Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 590913002: ChromeVox spoken feedback test using shift and search keys. (Closed)

Created:
6 years, 3 months ago by dmazzoni
Modified:
6 years, 2 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@chromevox_keyboard_tests_again_3
Project:
chromium
Visibility:
Public.

Description

ChromeVox spoken feedback test using shift and search keys. Split off from cl 490443002 because for some reason this test seems to fail with a NaCl error on one of the trybots. Let's try to land it separately. BUG=404470 Committed: https://crrev.com/97ec806ebc437afbbdd7657062f6fbca1d708dcc Cr-Commit-Position: refs/heads/master@{#296833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dmazzoni
David, PTAL. This is the test that was split off from the other change due ...
6 years, 3 months ago (2014-09-23 18:21:42 UTC) #2
David Tseng
lgtm
6 years, 2 months ago (2014-09-25 22:57:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590913002/1
6 years, 2 months ago (2014-09-25 23:02:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3124e5ea48843fb7a9f48b6bf7e159194c85b3f3
6 years, 2 months ago (2014-09-25 23:44:55 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 23:45:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97ec806ebc437afbbdd7657062f6fbca1d708dcc
Cr-Commit-Position: refs/heads/master@{#296833}

Powered by Google App Engine
This is Rietveld 408576698