Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 590873002: Move image_unittest_util* into gfx_test_support target. (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move image_unittest_util* into gfx_test_support target. That way we can stop building it within unit_tests and gfx_unittests and share with them through gfx_test_support target. This way is much more standard in chromium code. BUG=354137 TEST=unit_tests, gfx_unittests R=sky@chromium.org Committed: https://crrev.com/db2b7895e5739487fda1db0d99b113c364631773 Cr-Commit-Position: refs/heads/master@{#296004}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/gfx_tests.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
6 years, 3 months ago (2014-09-21 13:41:13 UTC) #1
sky
LGTM
6 years, 3 months ago (2014-09-22 16:21:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590873002/1
6 years, 3 months ago (2014-09-22 17:09:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 06fb49ac0ee756b60a6ee13e55f16266d62834be
6 years, 3 months ago (2014-09-22 17:15:37 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 17:16:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db2b7895e5739487fda1db0d99b113c364631773
Cr-Commit-Position: refs/heads/master@{#296004}

Powered by Google App Engine
This is Rietveld 408576698