Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 590863002: Enable the dependency on google_toolbox_for_mac. (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable the dependency on google_toolbox_for_mac. We converted this target to GN already, so app_list can depend on it as is. This should address the TODO(GYP) in the BUILD.gn file. BUG=None TEST=None R=brettw@chromium.org TBR=xiyuan@chromium.org,mark@chromium.org Committed: https://crrev.com/fd1b08582a03e13af0ed5136473d447065947e96 Cr-Commit-Position: refs/heads/master@{#297123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -203 lines) Patch
D build/secondary/third_party/google_toolbox_for_mac/BUILD.gn View 1 chunk +0 lines, -203 lines 0 comments Download
A + third_party/google_toolbox_for_mac/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/app_list/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
tfarina
6 years, 3 months ago (2014-09-21 13:33:21 UTC) #1
brettw
lgtm
6 years, 3 months ago (2014-09-22 01:50:03 UTC) #2
tfarina
TBR xiyuan for app_list and mark for google_toolbox_for_mac.
6 years, 2 months ago (2014-09-28 00:15:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590863002/1
6 years, 2 months ago (2014-09-28 00:16:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7764efcda226ec20b9802338cbee74f6e6ef2fe6
6 years, 2 months ago (2014-09-28 01:47:06 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-28 01:47:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd1b08582a03e13af0ed5136473d447065947e96
Cr-Commit-Position: refs/heads/master@{#297123}

Powered by Google App Engine
This is Rietveld 408576698