Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 590833002: Simplify synthetic roots creation in heap snapshot (Closed)

Created:
6 years, 3 months ago by yurys
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Simplify synthetic roots creation in heap snapshot The synthetic roots exist in every snapshot and there are no actual objects corresponding to them (there was attempt to create some virtual objects to reuse existing snapshot builder but it just complicated the things). Previously synthetic root wouldn't have been added if it was empty. Current implementation always adds all synthetic roots in the snapshot no matter if they are empty or not. BUG=None LOG=N R=alph@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24124

Patch Set 1 #

Patch Set 2 : Fixed test failures #

Patch Set 3 : Fixed compilation failire in dbg mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -110 lines) Patch
M src/heap-snapshot-generator.h View 8 chunks +6 lines, -19 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 2 10 chunks +24 lines, -72 lines 0 comments Download
M src/heap-snapshot-generator-inl.h View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yurys
6 years, 3 months ago (2014-09-21 06:32:52 UTC) #2
alph
lgtm!
6 years, 3 months ago (2014-09-22 11:09:51 UTC) #3
yurys
@hpayer: please do OWNERS review
6 years, 3 months ago (2014-09-22 11:26:20 UTC) #5
yurys
@mstarzinger: please do OWNERS review since Hannes seems to be in MTV.
6 years, 3 months ago (2014-09-22 11:31:38 UTC) #7
Michael Starzinger
LGTM (rubber-stamped).
6 years, 3 months ago (2014-09-22 12:02:25 UTC) #8
yurys
6 years, 3 months ago (2014-09-22 14:41:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 24124 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698