Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 59083013: Add 'Clear local data and reload' button in chrome:drive-internals. (Closed)

Created:
7 years, 1 month ago by kinaba
Modified:
7 years, 1 month ago
Reviewers:
yoshiki, satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Add 'Clear local data and reload' button in chrome:drive-internals. BUG=298789 R=satorux@chromium.org, yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233445

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Address comments (#2). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M chrome/browser/resources/chromeos/drive_internals.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/drive_internals.js View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 3 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
kinaba
ptal
7 years, 1 month ago (2013-11-06 07:26:59 UTC) #1
satorux1
lgtm with a nit https://codereview.chromium.org/59083013/diff/30001/chrome/browser/resources/chromeos/drive_internals.html File chrome/browser/resources/chromeos/drive_internals.html (right): https://codereview.chromium.org/59083013/diff/30001/chrome/browser/resources/chromeos/drive_internals.html#newcode38 chrome/browser/resources/chromeos/drive_internals.html:38: >Clear local data and reload</button> ...
7 years, 1 month ago (2013-11-06 07:34:26 UTC) #2
kinaba
https://codereview.chromium.org/59083013/diff/30001/chrome/browser/resources/chromeos/drive_internals.html File chrome/browser/resources/chromeos/drive_internals.html (right): https://codereview.chromium.org/59083013/diff/30001/chrome/browser/resources/chromeos/drive_internals.html#newcode38 chrome/browser/resources/chromeos/drive_internals.html:38: >Clear local data and reload</button> On 2013/11/06 07:34:27, satorux1 ...
7 years, 1 month ago (2013-11-06 07:36:45 UTC) #3
yoshiki
JS lgtm
7 years, 1 month ago (2013-11-06 07:40:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/59083013/90001
7 years, 1 month ago (2013-11-06 07:43:34 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94723
7 years, 1 month ago (2013-11-06 11:03:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/59083013/90001
7 years, 1 month ago (2013-11-06 11:29:33 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94832
7 years, 1 month ago (2013-11-06 15:03:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/59083013/90001
7 years, 1 month ago (2013-11-06 23:33:02 UTC) #9
kinaba
7 years, 1 month ago (2013-11-07 00:54:03 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 manually as r233445 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698