Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3122)

Unified Diff: base/memory/discardable_memory_provider_unittest.cc

Issue 59083011: base: Avoid purging more discardable memory than necessary. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: better comment Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/memory/discardable_memory_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/discardable_memory_provider_unittest.cc
diff --git a/base/memory/discardable_memory_provider_unittest.cc b/base/memory/discardable_memory_provider_unittest.cc
index f033a0524e727ab1d314b50b31faca888123901c..a1294fbcde9e3034b16065f703d748a923b212ff 100644
--- a/base/memory/discardable_memory_provider_unittest.cc
+++ b/base/memory/discardable_memory_provider_unittest.cc
@@ -232,6 +232,22 @@ TEST_P(DiscardableMemoryProviderPermutationTest, LRUDiscardedExceedLimit) {
EXPECT_NE(static_cast<void*>(NULL), Memory(discardable(0)));
}
+// Verify that no more memory than necessary was discarded after changing
+// memory limit.
+TEST_P(DiscardableMemoryProviderPermutationTest, LRUDiscardedAmount) {
+ SetBytesToReclaimUnderModeratePressure(2048);
+ SetDiscardableMemoryLimit(4096);
+
+ CreateAndUseDiscardableMemory();
+
+ SetDiscardableMemoryLimit(2048);
+
+ EXPECT_EQ(DISCARDABLE_MEMORY_SUCCESS, discardable(2)->Lock());
+ EXPECT_EQ(DISCARDABLE_MEMORY_PURGED, discardable(1)->Lock());
+ // 0 should still be locked.
+ EXPECT_NE(static_cast<void*>(NULL), Memory(discardable(0)));
+}
+
TEST_P(DiscardableMemoryProviderPermutationTest,
CriticalPressureFreesAllUnlocked) {
CreateAndUseDiscardableMemory();
« no previous file with comments | « base/memory/discardable_memory_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698