"Fix" bug in debug canvas

src/utils/debugger/SkDebugCanvas.cpp

Index: src/utils/debugger/SkDebugCanvas.cpp
===================================================================
--- src/utils/debugger/SkDebugCanvas.cpp	(revision 12088)
+++ src/utils/debugger/SkDebugCanvas.cpp	(working copy)
@@ -35,6 +35,16 @@
     fFilter = false;
     fIndex = 0;
     fUserMatrix.reset();
+
+    // SkPicturePlayback uses the base-class' quickReject calls to cull clipped
+    // operations. This can lead to problems in the debugger which expects all
+    // the operations in the captured skp to appear in the debug canvas. To
+    // circumvent this we create a wide open clip here (an empty clip rect
+    // is not sufficient).
+    SkIRect largeIRect = SkIRect::MakeLargest();
+    largeIRect.inset(100, 100);

[Justin Novosad, 2013/11/06 18:01:55]

Why the inset?

[robertphillips, 2013/11/06 18:59:15]

The SkRect is converted to an SkIRect internally and then rounded out. Setting
it to the largest IRect results in the rect collapsing during the rounding out
process.

+    SkRect large = SkRect::MakeFromIRect(largeIRect);
+    INHERITED::clipRect(large, SkRegion::kReplace_Op, false);
 }
 
 SkDebugCanvas::~SkDebugCanvas() {