Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 59073006: Do not show most startup infobars in browser tests. (Closed)

Created:
7 years, 1 month ago by earthdok
Modified:
7 years, 1 month ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Visibility:
Public.

Description

Do not show most startup infobars in browser tests. Prevent startup infobars (e.g. when running with --no-sandbox) from interfering with tests which assume no pre-existing infobars. BUG=315059 R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233452

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
earthdok
PTAL
7 years, 1 month ago (2013-11-06 15:29:03 UTC) #1
Peter Kasting
LGTM
7 years, 1 month ago (2013-11-06 20:07:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/59073006/1
7 years, 1 month ago (2013-11-06 21:15:42 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 01:02:39 UTC) #4
Message was sent while issue was closed.
Change committed as 233452

Powered by Google App Engine
This is Rietveld 408576698