Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: dart/runtime/lib/isolate_patch.dart

Issue 59073003: Version 0.8.10.4 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/runtime/lib/isolate.cc ('k') | dart/runtime/lib/mirrors_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/runtime/lib/isolate_patch.dart
===================================================================
--- dart/runtime/lib/isolate_patch.dart (revision 29808)
+++ dart/runtime/lib/isolate_patch.dart (working copy)
@@ -110,15 +110,10 @@
class _SendPortImpl implements SendPort {
/*--- public interface ---*/
- void send(var message, [SendPort replyTo = null]) {
- this._sendNow(message, replyTo);
+ void send(var message) {
+ _sendInternal(_id, 0, message);
}
- void _sendNow(var message, SendPort replyTo) {
- int replyId = (replyTo == null) ? 0 : replyTo._id;
- _sendInternal(_id, replyId, message);
- }
-
bool operator==(var other) {
return (other is _SendPortImpl) && _id == other._id;
}
@@ -145,6 +140,7 @@
// Forward the implementation of sending messages to the VM. Only port ids
// are being handed to the VM.
+ // TODO(14731): Remove replyId argument.
static _sendInternal(int sendId, int replyId, var message)
native "SendPortImpl_sendInternal_";
@@ -178,8 +174,10 @@
keepAlivePort.close();
SendPort replyTo = message[0];
- // TODO(floitsch): don't send ok-message if we can't find the entry point.
- replyTo.send("started");
+ if (replyTo != null) {
+ // TODO(floitsch): don't send ok-message if we can't find the entry point.
+ replyTo.send("started");
+ }
if (isSpawnUri) {
assert(message.length == 3);
List<String> args = message[1];
« no previous file with comments | « dart/runtime/lib/isolate.cc ('k') | dart/runtime/lib/mirrors_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698