Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: dart/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java

Issue 59073003: Version 0.8.10.4 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java
===================================================================
--- dart/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java (revision 29808)
+++ dart/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java (working copy)
@@ -724,7 +724,7 @@
RETURN_WITHOUT_VALUE("Missing return value after 'return'"),
/**
- * 12.15.3 Static Invocation: It is a static warning if <i>C</i> does not declare a static method
+ * 12.16.3 Static Invocation: It is a static warning if <i>C</i> does not declare a static method
* or getter <i>m</i>.
*
* @param memberName the name of the instance member
@@ -754,7 +754,7 @@
TYPE_PARAMETER_REFERENCED_BY_STATIC("Static members cannot reference type parameters"),
/**
- * 12.15.3 Static Invocation: A static method invocation <i>i</i> has the form
+ * 12.16.3 Static Invocation: A static method invocation <i>i</i> has the form
* <i>C.m(a<sub>1</sub>, &hellip;, a<sub>n</sub>, x<sub>n+1</sub>: a<sub>n+1</sub>, &hellip;
* x<sub>n+k</sub>: a<sub>n+k</sub>)</i>. It is a static warning if <i>C</i> does not denote a
* class in the current scope.
@@ -815,14 +815,14 @@
UNDEFINED_SETTER("There is no such setter '%s' in '%s'"),
/**
- * 12.15.3 Static Invocation: It is a static warning if <i>C</i> does not declare a static method
+ * 12.16.3 Static Invocation: It is a static warning if <i>C</i> does not declare a static method
* or getter <i>m</i>.
*
* @param methodName the name of the method
* @param enclosingType the name of the enclosing type where the method is being looked for
*/
- // TODO(jwren) Even though we have a message here, this warning code is not being generated.
- UNDEFINED_STATIC_METHOD_OR_GETTER("There is no such static method '%s' in '%s'");
+ // Note: all cases of this method are covered by the StaticWarningCode.UNDEFINED_METHOD/UNDEFINED_GETTER and UNDEFINED_SETTER codes
+ UNDEFINED_STATIC_METHOD_OR_GETTER("There is no such static method, getter or setter '%s' in '%s'");
/**
* The template used to create the message to be displayed for this error.

Powered by Google App Engine
This is Rietveld 408576698