Issue 590683002: gn: Fix some typos in unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 590683002: gn: Fix some typos in unittests. (Closed)

Created:
6 years, 3 months ago by tfarina

Modified:
6 years, 3 months ago

Reviewers:
brettw

CC:
chromium-reviews, scottmg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

gn: Fix some typos in unittests. SubstitutionPatterm -> SubstitutionPattern SubstutitionWriter -> SubstitutionWriter BUG=None TEST=ninja -C out/Debug gn_unittests - compare the output before and after this change. TBR=brettw@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/4b070e30d517598abb1c9a740d5829cf9212dcff

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/gn/substitution_pattern_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/gn/substitution_writer_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/4b070e30d517598abb1c9a740d5829cf9212dcff Cr-Commit-Position: refs/heads/master@{#295846}

6 years, 3 months ago (2014-09-20 02:26:12 UTC) #2

tfarina

Committed patchset #1 (id:1) manually as 4b070e3 (presubmit successful).

6 years, 3 months ago (2014-09-20 02:26:16 UTC) #3

Message was sent while issue was closed.

lgtm