Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4569)

Unified Diff: chrome/test/chromedriver/server/chromedriver_server.cc

Issue 590653002: [chromedriver] Remove extra call to HttpServer::Close() and increase TestHttpServer buffer limit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/net/test_http_server.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/server/chromedriver_server.cc
diff --git a/chrome/test/chromedriver/server/chromedriver_server.cc b/chrome/test/chromedriver/server/chromedriver_server.cc
index 2508c59ae50a5e8015c777816844b6f586630b70..c5c93e92d8f29e94cdd52cf06c3e79cc5fa2efb8 100644
--- a/chrome/test/chromedriver/server/chromedriver_server.cc
+++ b/chrome/test/chromedriver/server/chromedriver_server.cc
@@ -87,7 +87,6 @@ class HttpServer : public net::HttpServer::Delegate {
// the connection to close (e.g., python 2.7 urllib).
response->AddHeader("Connection", "close");
server_->SendResponse(connection_id, *response);
- server_->Close(connection_id);
stgao 2014/09/20 02:10:04 Why we don't have to close the connection now? Is
}
HttpRequestHandlerFunc handle_request_func_;
« no previous file with comments | « chrome/test/chromedriver/net/test_http_server.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698