Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 590653002: [chromedriver] Remove extra call to HttpServer::Close() and increase TestHttpServer buffer limit (Closed)

Created:
6 years, 3 months ago by samuong
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, stgao, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Remove extra call to HttpServer::Close() and increase TestHttpServer buffer limit BUG= TBR=stgao@chromium.org Committed: https://crrev.com/92354ccd6e5d1123685cb384a3e08425d801017d Cr-Commit-Position: refs/heads/master@{#295871}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M chrome/test/chromedriver/net/test_http_server.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/test_http_server.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/server/chromedriver_server.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
samuong
PTAL. This should fix the following tests on our waterfall: - TextHandlingTest.testReadALargeAmountOfData - SyncWebSocketImplTest.SendReceiveLarge - ...
6 years, 3 months ago (2014-09-20 01:04:36 UTC) #2
stgao
https://codereview.chromium.org/590653002/diff/1/chrome/test/chromedriver/server/chromedriver_server.cc File chrome/test/chromedriver/server/chromedriver_server.cc (left): https://codereview.chromium.org/590653002/diff/1/chrome/test/chromedriver/server/chromedriver_server.cc#oldcode90 chrome/test/chromedriver/server/chromedriver_server.cc:90: server_->Close(connection_id); Why we don't have to close the connection ...
6 years, 3 months ago (2014-09-20 02:10:04 UTC) #3
stgao
Hi Sam, Once my comment is addressed, please feel free to do a TBR to ...
6 years, 3 months ago (2014-09-20 06:19:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590653002/20001
6 years, 3 months ago (2014-09-20 06:27:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as e7ea1919961b9cc9b8ae4506f48085c058656667
6 years, 3 months ago (2014-09-20 13:21:47 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 13:22:21 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92354ccd6e5d1123685cb384a3e08425d801017d
Cr-Commit-Position: refs/heads/master@{#295871}

Powered by Google App Engine
This is Rietveld 408576698