chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js - Issue 590643002: Move Print Preview onto newer i18nTemplate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

Issue 590643002: Move Print Preview onto newer i18nTemplate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix open-preview-app-throbber Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/print_preview/print_preview.js ('K') | « chrome/browser/resources/print_preview/search/recent_destination_list.js ('k') | chrome/browser/resources/print_preview/settings/more_settings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

diff --git a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js b/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

index b4f5cc644cca19d5faccb65cab2a84d625372fca..9b6bc9516387c482db3a8ea8a6e058855d72ea58 100644

--- a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

+++ b/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

@@ -29,7 +29,7 @@ cr.define('print_preview', function() {

/** @private {!print_preview.SearchBox} */

this.searchBox_ = new print_preview.SearchBox(

- localStrings.getString('advancedSettingsSearchBoxPlaceholder'));

+ loadTimeData.getString('advancedSettingsSearchBoxPlaceholder'));

this.addChild(this.searchBox_);

/** @private {print_preview.Destination} */

@@ -59,7 +59,7 @@ cr.define('print_preview', function() {

assert(!this.destination_);

this.destination_ = destination;

this.getChildElement('.advanced-settings-title').textContent =

- localStrings.getStringF('advancedSettingsDialogTitle',

+ loadTimeData.getStringF('advancedSettingsDialogTitle',

this.destination_.displayName);

this.setIsVisible(true);

this.renderSettings_();