chrome/browser/resources/print_preview/previewarea/margin_control.js - Issue 590643002: Move Print Preview onto newer i18nTemplate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/previewarea/margin_control.js

Issue 590643002: Move Print Preview onto newer i18nTemplate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix open-preview-app-throbber Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/data/destination_store.js ('k') | chrome/browser/resources/print_preview/previewarea/preview_area.js » ('j') | chrome/browser/resources/print_preview/print_preview.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/previewarea/margin_control.js

diff --git a/chrome/browser/resources/print_preview/previewarea/margin_control.js b/chrome/browser/resources/print_preview/previewarea/margin_control.js

index 5f9012f7619def2cffd74c2158d1724f13416ea2..247cad9547cbe968b99d0b2e333aaecfd2b88a4a 100644

--- a/chrome/browser/resources/print_preview/previewarea/margin_control.js

+++ b/chrome/browser/resources/print_preview/previewarea/margin_control.js

@@ -313,7 +313,7 @@ cr.define('print_preview', function() {

this.textbox_ = this.getElement().getElementsByClassName(

MarginControl.Classes_.TEXTBOX)[0];

this.textbox_.setAttribute(

- 'aria-label', localStrings.getString(this.orientation_));

+ 'aria-label', loadTimeData.getString(this.orientation_));

this.marginLineEl_ = this.getElement().getElementsByClassName(

MarginControl.Classes_.LINE)[0];