Move Print Preview onto newer i18nTemplate

chrome/browser/resources/print_preview/print_preview.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(rltoscano): Move data/* into print_preview.data namespace
 
-var localStrings = new LocalStrings(templateData);
-
 <include src="component.js"/>
 <include src="print_preview_focus_manager.js"/>
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * Container class for Chromium's print preview.
    * @constructor
    * @extends {print_preview.Component}
@@ skipping 269 matching lines @@
     PRINTED: 'printed',
     READY_WAITING_FOR_PREVIEW: 'ready-waiting-for-preview'
   };
 
   PrintPreview.prototype = {
     __proto__: print_preview.Component.prototype,
 
     /** Sets up the page and print preview by getting the printer list. */
     initialize: function() {
       this.decorate($('print-preview'));
-      i18nTemplate.process(document, templateData);
       if (!this.previewArea_.hasCompatiblePlugin) {
         this.setIsEnabled_(false);
       }
       this.nativeLayer_.startGetInitialSettings();
       print_preview.PrintPreviewFocusManager.getInstance().initialize();
       cr.ui.FocusOutlineManager.forDocument(document);
     },
 
     /** @override */
     enterDocument: function() {
@@ skipping 36 matching lines @@
           this.onManipulateSettingsForTest_.bind(this));
 
       this.tracker.add(
           $('system-dialog-link'),
           'click',
           this.openSystemPrintDialog_.bind(this));
       this.tracker.add(
           $('cloud-print-dialog-link'),
           'click',
           this.onCloudPrintDialogLinkClick_.bind(this));
-      this.tracker.add(
-          $('open-pdf-in-preview-link'),
-          'click',
-          this.onOpenPdfInPreviewLinkClick_.bind(this));
+      if ($('open-pdf-in-preview-link')) {
+        this.tracker.add(
+            $('open-pdf-in-preview-link'),
+            'click',
+            this.onOpenPdfInPreviewLinkClick_.bind(this));
+      }
 
       this.tracker.add(
           this.previewArea_,
           print_preview.PreviewArea.EventType.PREVIEW_GENERATION_IN_PROGRESS,
           this.onPreviewGenerationInProgress_.bind(this));
       this.tracker.add(
           this.previewArea_,
           print_preview.PreviewArea.EventType.PREVIEW_GENERATION_DONE,
           this.onPreviewGenerationDone_.bind(this));
       this.tracker.add(
@@ skipping 86 matching lines @@
       this.copiesSettings_.decorate($('copies-settings'));
       this.mediaSizeSettings_.decorate($('media-size-settings'));
       this.layoutSettings_.decorate($('layout-settings'));
       this.colorSettings_.decorate($('color-settings'));
       this.marginSettings_.decorate($('margin-settings'));
       this.otherOptionsSettings_.decorate($('other-options-settings'));
       this.advancedOptionsSettings_.decorate($('advanced-options-settings'));
       this.advancedSettings_.decorate($('advanced-settings'));
       this.moreSettings_.decorate($('more-settings'));
       this.previewArea_.decorate($('preview-area'));
-
-      setIsVisible($('open-pdf-in-preview-link'), cr.isMac);
     },
 
     /**
      * Sets whether the controls in the print preview are enabled.
      * @param {boolean} isEnabled Whether the controls in the print preview are
      *     enabled.
      * @private
      */
     setIsEnabled_: function(isEnabled) {
       $('system-dialog-link').disabled = !isEnabled;
       $('cloud-print-dialog-link').disabled = !isEnabled;
-      $('open-pdf-in-preview-link').disabled = !isEnabled;
+      if ($('open-pdf-in-preview-link')) {
+        $('open-pdf-in-preview-link').disabled = !isEnabled;
+      }
       this.printHeader_.isEnabled = isEnabled;
       this.destinationSettings_.isEnabled = isEnabled;
       this.pageSettings_.isEnabled = isEnabled;
       this.copiesSettings_.isEnabled = isEnabled;
       this.mediaSizeSettings_.isEnabled = isEnabled;
       this.layoutSettings_.isEnabled = isEnabled;
       this.colorSettings_.isEnabled = isEnabled;
       this.marginSettings_.isEnabled = isEnabled;
       this.otherOptionsSettings_.isEnabled = isEnabled;
       this.advancedOptionsSettings_.isEnabled = isEnabled;
@@ skipping 214 matching lines @@
 
     /**
      * Called from the native layer when save-to-pdf file selection is complete.
      * @private
      */
     onFileSelectionComplete_: function() {
       assert(this.uiState_ == PrintPreview.UiState_.FILE_SELECTION,
              'File selection completed when not in file-selection state: ' +
                  this.uiState_);
       this.previewArea_.showCustomMessage(
-          localStrings.getString('printingToPDFInProgress'));
+          loadTimeData.getString('printingToPDFInProgress'));
       this.uiState_ = PrintPreview.UiState_.PRINTING;
     },
 
     /**
      * Called after successfully submitting a job to Google Cloud Print.
      * @param {!Event} event Contains the ID of the submitted print job.
      * @private
      */
     onCloudPrintSubmitDone_: function(event) {
       assert(this.uiState_ == PrintPreview.UiState_.PRINTING,
@@ skipping 70 matching lines @@
      * Called when the 'Open pdf in preview' link is clicked. Launches the pdf
      * preview app.
      * @private
      */
     onOpenPdfInPreviewLinkClick_: function() {
       assert(this.uiState_ == PrintPreview.UiState_.READY,
              'Trying to open pdf in preview when not in ready state: ' +
                  this.uiState_);
       setIsVisible($('open-preview-app-throbber'), true);
       this.previewArea_.showCustomMessage(
-          localStrings.getString('openingPDFInPreview'));
+          loadTimeData.getString('openingPDFInPreview'));
       this.printDocumentOrOpenPdfPreview_(true /*isPdfPreview*/);
     },
 
     /**
      * Called when the print header's print button is clicked. Prints the
      * document.
      * @private
      */
     onPrintButtonClick_: function() {
       assert(this.uiState_ == PrintPreview.UiState_.READY,
@@ skipping 79 matching lines @@
     },
 
     /**
      * Called when native layer receives invalid settings for a print request.
      * @private
      */
     onSettingsInvalid_: function() {
       this.uiState_ = PrintPreview.UiState_.ERROR;
       console.error('Invalid settings error reported from native layer');
       this.previewArea_.showCustomMessage(
-          localStrings.getString('invalidPrinterSettings'));
+          loadTimeData.getString('invalidPrinterSettings'));
     },
 
     /**
      * Called when the destination settings' change button is activated.
      * Displays the destination search component.
      * @private
      */
     onDestinationChangeButtonActivate_: function() {
       this.destinationSearch_.setIsVisible(true);
       this.destinationStore_.startLoadCloudDestinations();
@@ skipping 52 matching lines @@
 
     /**
      * Called when privet printing fails.
      * @param {Event} event Event object representing the failure.
      * @private
      */
     onPrivetPrintFailed_: function(event) {
       console.error('Privet printing failed with error code ' +
                     event.httpError);
       this.printHeader_.setErrorMessage(
-        localStrings.getString('couldNotPrint'));
+        loadTimeData.getString('couldNotPrint'));

[Vitaly Buka (NO REVIEWS), 2014/09/20 03:51:13]

two more spaces

[Evan Stade, 2014/09/22 20:15:48]

Done.

     },
 
     /**
      * Called when the print preview settings need to be changed for testing.
      * @param {Event} event Event object that contains the option that is to
      *     be changed and what to set that option.
      * @private
      */
     onManipulateSettingsForTest_: function(event) {
       if ('selectSaveAsPdfDestination' in event.settings) {
@@ skipping 298 matching lines @@
 <include src="search/cloud_destination_list.js"/>
 <include src="search/recent_destination_list.js"/>
 <include src="search/destination_list_item.js"/>
 <include src="search/destination_search.js"/>
 <include src="search/fedex_tos.js"/>
 
 window.addEventListener('DOMContentLoaded', function() {
   printPreview = new print_preview.PrintPreview();
   printPreview.initialize();
 });