Move Print Preview onto newer i18nTemplate

Move Print Preview onto newer i18nTemplate

BUG=122753
Committed: https://crrev.com/6ba6b1485114bdda7f8be54cbf0443046ccc3034
Cr-Commit-Position: refs/heads/master@{#296076}

[Evan Stade, 2014-09-20 00:22:14]

estade@chromium.org changed reviewers:
+ thestig@chromium.org

[Evan Stade, 2014-09-20 00:22:15]

Lei, how can I test this? Do you have a link to a pdf plugin  or instructions on
where to put it?

[Lei Zhang, 2014-09-20 00:26:42]

On 2014/09/20 00:22:15, Evan Stade wrote:
> Lei, how can I test this? Do you have a link to a pdf plugin  or instructions
on
> where to put it?

Print preview is on by default. PDFium is open source, so you probably have it
built already.

[Lei Zhang, 2014-09-20 00:28:12]

lgtm

[Evan Stade, 2014-09-20 00:49:05]

yea, it does work. Glad I tested, found a bug.

[Evan Stade, 2014-09-20 00:49:08]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-09-20 00:50:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/590643002/20001

[commit-bot: I haz the power, 2014-09-20 00:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-20 00:56:28]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/58591)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[commit-bot: I haz the power, 2014-09-20 00:56:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-20 00:56:45]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/58591)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[Vitaly Buka (NO REVIEWS), 2014-09-20 03:51:12]

vitalybuka@chromium.org changed reviewers:
+ vitalybuka@chromium.org

[Vitaly Buka (NO REVIEWS), 2014-09-20 03:51:13]

lgtm

https://codereview.chromium.org/590643002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/print_preview/print_preview.js (right):

https://codereview.chromium.org/590643002/diff/20001/chrome/browser/resources...
chrome/browser/resources/print_preview/print_preview.js:976:
loadTimeData.getString('couldNotPrint'));
two more spaces

[Evan Stade, 2014-09-22 20:15:48]

https://codereview.chromium.org/590643002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/print_preview/print_preview.js (right):

https://codereview.chromium.org/590643002/diff/20001/chrome/browser/resources...
chrome/browser/resources/print_preview/print_preview.js:976:
loadTimeData.getString('couldNotPrint'));
On 2014/09/20 03:51:13, Vitaly Buka wrote:
> two more spaces

Done.

[Evan Stade, 2014-09-22 20:27:07]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-09-22 20:28:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/590643002/40001

[Evan Stade, 2014-09-22 21:38:23]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-09-22 21:38:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/590643002/60001

[commit-bot: I haz the power, 2014-09-22 22:43:22]

Committed patchset #4 (id:60001) as 3bdb1457d9880b492ddf71b1b24a75e9a7fe4cfc

[commit-bot: I haz the power, 2014-09-22 22:43:59]

Patchset 4 (id:??) landed as
https://crrev.com/6ba6b1485114bdda7f8be54cbf0443046ccc3034
Cr-Commit-Position: refs/heads/master@{#296076}