Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 59063009: ActivationTrackerWin: General refactor, renaming and clarification. (Closed)

Created:
7 years, 1 month ago by Matt Giuca
Modified:
7 years, 1 month ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, tapted, benwells
Visibility:
Public.

Description

ActivationTrackerWin: General refactor, renaming and clarification. I found this class quite difficult to understand, mostly due to bad method and variable names. Renamed: CheckTaskbarOrViewHasFocus -> MaybeDismissAppList, RegainNextLostFocus -> ReactivateOnNextFocusLoss, regain_next_lost_focus_ -> reactivate_on_next_focus_loss_, preserving_focus_for_taskbar_menu_ -> taskbar_has_focus_, and rewrote many of the comments for clarity. Factored out most of the logic in MaybeDismissAppList to ShouldDismissAppList, which returns a bool and has minimal side effects. This also introduces a minor behavioural fix: If the focused window is NULL, and reactivate_on_next_focus_loss is true, reactivates instead of dismissing. BUG=307837 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233244

Patch Set 1 #

Patch Set 2 : Small cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -61 lines) Patch
M chrome/browser/ui/app_list/app_list.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_shower.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/test/app_list_shower_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/app_list/win/activation_tracker_win.h View 3 chunks +21 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/activation_tracker_win.cc View 1 4 chunks +49 lines, -43 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Matt Giuca
7 years, 1 month ago (2013-11-06 04:00:50 UTC) #1
koz (OOO until 15th September)
lgtm! Awesome change, Matt! Thanks for this.
7 years, 1 month ago (2013-11-06 04:19:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/59063009/20001
7 years, 1 month ago (2013-11-06 04:39:14 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=98434
7 years, 1 month ago (2013-11-06 07:52:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/59063009/20001
7 years, 1 month ago (2013-11-06 08:23:09 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 08:26:29 UTC) #6
Message was sent while issue was closed.
Change committed as 233244

Powered by Google App Engine
This is Rietveld 408576698