Issue 59063005: rebaseline_server was not allowing tests to be marked ignore-failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59063005: rebaseline_server was not allowing tests to be marked ignore-failure (Closed)

Created:
7 years, 1 month ago by epoger

Modified:
7 years, 1 month ago

Reviewers:
jcgregorio

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

rebaseline_server was not allowing tests to be marked ignore-failure (SkipBuildbotRuns) TBR=jcgregorio Committed: https://code.google.com/p/skia/source/detail?r=12143

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	gm/rebaseline_server/static/loader.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	gm/rebaseline_server/static/view.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

epoger

Committed patchset #1 manually as r12143 (presubmit successful).

7 years, 1 month ago (2013-11-05 21:00:26 UTC) #1

jcgregorio

On 2013/11/05 21:00:41, epoger wrote: > committed TBR LGTM Do we have a plan for ...

7 years, 1 month ago (2013-11-05 21:03:25 UTC) #3

epoger

7 years, 1 month ago (2013-11-05 21:04:18 UTC) #4

Message was sent while issue was closed.

On 2013/11/05 21:03:25, jcgregorio wrote:
> On 2013/11/05 21:00:41, epoger wrote:
> > committed TBR
> 
> LGTM
> 
> Do we have a plan for unit tests?

Excellent question.  The answer is: no we don't, but we should.

Expand Messages | Collapse Messages