Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1872)

Unified Diff: Source/web/LinkHighlight.cpp

Issue 59063003: Don't coerce pointers to compositor layer mappings to booleans. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Respond to reviewer feedback. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/LinkHighlight.cpp
diff --git a/Source/web/LinkHighlight.cpp b/Source/web/LinkHighlight.cpp
index 4f32739267b200111858fb60827d2639405447fc..ed6ba1f98c7dfb1ea166508ac455f611d8194926 100644
--- a/Source/web/LinkHighlight.cpp
+++ b/Source/web/LinkHighlight.cpp
@@ -131,7 +131,7 @@ RenderLayer* LinkHighlight::computeEnclosingCompositingLayer()
if (!newGraphicsLayer->drawsContent()) {
if (renderLayer->scrollableArea()->usesCompositedScrolling()) {
- ASSERT(renderLayer->compositedLayerMapping() && renderLayer->compositedLayerMapping()->scrollingContentsLayer());
+ ASSERT(renderLayer->compositingState() == PaintsIntoOwnBacking && renderLayer->compositedLayerMapping()->scrollingContentsLayer());
shawnsingh 2013/11/12 09:55:50 Can you please explain? I actually am not familiar
Ian Vollick 2013/11/14 04:12:47 It's just that if the renderLayer uses composited
newGraphicsLayer = renderLayer->compositedLayerMapping()->scrollingContentsLayer();
} else
ASSERT_NOT_REACHED();

Powered by Google App Engine
This is Rietveld 408576698