Source/web/LinkHighlight.cpp - Issue 59063003: Don't coerce pointers to compositor layer mappings to booleans.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/LinkHighlight.cpp

Issue 59063003: Don't coerce pointers to compositor layer mappings to booleans. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed ASSERTS and a circular dependency in CompositedLayerMapping::updateCompositedBounds. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/LinkHighlight.cpp

diff --git a/Source/web/LinkHighlight.cpp b/Source/web/LinkHighlight.cpp

index 4f32739267b200111858fb60827d2639405447fc..ed6ba1f98c7dfb1ea166508ac455f611d8194926 100644

--- a/Source/web/LinkHighlight.cpp

+++ b/Source/web/LinkHighlight.cpp

@@ -131,7 +131,7 @@ RenderLayer* LinkHighlight::computeEnclosingCompositingLayer()

if (!newGraphicsLayer->drawsContent()) {

if (renderLayer->scrollableArea()->usesCompositedScrolling()) {

- ASSERT(renderLayer->compositedLayerMapping() && renderLayer->compositedLayerMapping()->scrollingContentsLayer());

+ ASSERT(renderLayer->compositingState() == PaintsIntoOwnBacking && renderLayer->compositedLayerMapping()->scrollingContentsLayer());

newGraphicsLayer = renderLayer->compositedLayerMapping()->scrollingContentsLayer();

} else

ASSERT_NOT_REACHED();