Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 590603002: Remove ExtensionAPIClient::IsWebViewRequest (Closed)

Created:
6 years, 3 months ago by Fady Samuel
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove ExtensionAPIClient::IsWebViewRequest This is a silly remnant of the extensions refactor. We go to chrome to go back to extensions. This removes this API and calls IsWebViewRequest directly. BUG=352293 TBR=sky@chromium.org for code deletion in chrome_extensions_browser_client Committed: https://crrev.com/dc8c94f20c8336b3b5b46a4b85a318788648932f Cr-Commit-Position: refs/heads/master@{#295872}

Patch Set 1 #

Patch Set 2 : Fixed silly bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
M chrome/browser/extensions/chrome_extensions_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M extensions/browser/extension_protocols.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/extensions_browser_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/test_extensions_browser_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Fady Samuel
+sky@ for chrome changes +rockot@ for extensions changes.
6 years, 3 months ago (2014-09-19 22:15:07 UTC) #2
Fady Samuel
PTAL
6 years, 3 months ago (2014-09-19 22:25:34 UTC) #3
Ken Rockot(use gerrit already)
woot! I love deleted code lgtm
6 years, 3 months ago (2014-09-19 23:14:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590603002/20001
6 years, 3 months ago (2014-09-20 09:08:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590603002/20001
6 years, 3 months ago (2014-09-20 09:08:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 1835dc11b54611d78bb4f7221163350a72b72f7c
6 years, 3 months ago (2014-09-20 13:22:10 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 13:22:55 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc8c94f20c8336b3b5b46a4b85a318788648932f
Cr-Commit-Position: refs/heads/master@{#295872}

Powered by Google App Engine
This is Rietveld 408576698