Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5152)

Unified Diff: chrome/browser/extensions/api/declarative_content/content_rules_registry_unittest.cc

Issue 590573002: Remove ContentRulesRegistry dependence from RulesRegistryService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative_content/content_rules_registry_unittest.cc
diff --git a/chrome/browser/extensions/api/declarative_content/content_rules_registry_unittest.cc b/chrome/browser/extensions/api/declarative_content/content_rules_registry_unittest.cc
deleted file mode 100644
index c55736b82086b08a1022552d18cef58fc8e4ea98..0000000000000000000000000000000000000000
--- a/chrome/browser/extensions/api/declarative_content/content_rules_registry_unittest.cc
+++ /dev/null
@@ -1,97 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/extensions/api/declarative_content/content_rules_registry.h"
-
-#include <string>
-
-#include "base/test/values_test_util.h"
-#include "chrome/browser/extensions/extension_tab_util.h"
-#include "chrome/browser/extensions/test_extension_environment.h"
-#include "chrome/test/base/testing_profile.h"
-#include "content/public/browser/navigation_details.h"
-#include "content/public/browser/web_contents.h"
-#include "content/public/common/frame_navigate_params.h"
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace extensions {
-
-using base::test::ParseJson;
-using testing::HasSubstr;
-using content::WebContents;
-
-// Must be outside the anonymous namespace to be a friend of
-// ContentRulesRegistry.
-class DeclarativeContentRulesRegistryTest : public testing::Test {
- protected:
- static const std::map<int, std::set<ContentRule*> >& active_rules(
- const ContentRulesRegistry& registry) {
- return registry.active_rules_;
- }
-};
-
-namespace {
-
-TEST_F(DeclarativeContentRulesRegistryTest, ActiveRulesDoesntGrow) {
- TestExtensionEnvironment env;
-
- scoped_refptr<ContentRulesRegistry> registry(
- new ContentRulesRegistry(env.profile(), NULL));
-
- EXPECT_EQ(0u, active_rules(*registry.get()).size());
-
- content::LoadCommittedDetails load_details;
- content::FrameNavigateParams navigate_params;
- scoped_ptr<WebContents> tab = env.MakeTab();
- registry->DidNavigateMainFrame(tab.get(), load_details, navigate_params);
- EXPECT_EQ(0u, active_rules(*registry.get()).size());
-
- // Add a rule.
- linked_ptr<RulesRegistry::Rule> rule(new RulesRegistry::Rule);
- RulesRegistry::Rule::Populate(
- *ParseJson(
- "{\n"
- " \"id\": \"rule1\",\n"
- " \"priority\": 100,\n"
- " \"conditions\": [\n"
- " {\n"
- " \"instanceType\": \"declarativeContent.PageStateMatcher\",\n"
- " \"css\": [\"input\"]\n"
- " }],\n"
- " \"actions\": [\n"
- " { \"instanceType\": \"declarativeContent.ShowPageAction\" }\n"
- " ]\n"
- "}"),
- rule.get());
- std::vector<linked_ptr<RulesRegistry::Rule> > rules;
- rules.push_back(rule);
-
- const Extension* extension = env.MakeExtension(*ParseJson(
- "{\"page_action\": {}}"));
- registry->AddRulesImpl(extension->id(), rules);
-
- registry->DidNavigateMainFrame(tab.get(), load_details, navigate_params);
- EXPECT_EQ(0u, active_rules(*registry.get()).size());
-
- std::vector<std::string> css_selectors;
- css_selectors.push_back("input");
- registry->Apply(tab.get(), css_selectors);
- EXPECT_EQ(1u, active_rules(*registry.get()).size());
-
- // Closing the tab should erase its entry from active_rules_.
- tab.reset();
- EXPECT_EQ(0u, active_rules(*registry.get()).size());
-
- tab = env.MakeTab();
- registry->Apply(tab.get(), css_selectors);
- EXPECT_EQ(1u, active_rules(*registry.get()).size());
- // Navigating the tab should erase its entry from active_rules_ if
- // it no longer matches.
- registry->DidNavigateMainFrame(tab.get(), load_details, navigate_params);
- EXPECT_EQ(0u, active_rules(*registry.get()).size());
-}
-
-} // namespace
-} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/api/declarative_content/content_rules_registry.cc ('k') | chrome/browser/extensions/tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698