Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: extensions/browser/api/extensions_api_client.h

Issue 590573002: Remove ContentRulesRegistry dependence from RulesRegistryService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/extensions_api_client.h
diff --git a/extensions/browser/api/extensions_api_client.h b/extensions/browser/api/extensions_api_client.h
index 08c6e3196ddf3da9e940f3e2185c5d56fb91c110..2a2c9bebfcc6f5b03a93c2c8345ef2bb43484abe 100644
--- a/extensions/browser/api/extensions_api_client.h
+++ b/extensions/browser/api/extensions_api_client.h
@@ -24,6 +24,7 @@ class BrowserContext;
namespace extensions {
class AppViewGuestDelegate;
+class ContentRulesRegistry;
class ExtensionOptionsGuest;
class ExtensionOptionsGuestDelegate;
class MimeHandlerViewGuest;
@@ -32,6 +33,7 @@ class WebViewGuest;
class WebViewGuestDelegate;
class WebViewPermissionHelper;
class WebViewPermissionHelperDelegate;
+class RulesCacheDelegate;
class SettingsObserver;
class SettingsStorageFactory;
class ValueStoreCache;
@@ -90,6 +92,14 @@ class ExtensionsAPIClient {
const RulesRegistry::WebViewKey& webview_key,
const std::string& event_name);
+ // TODO(wjmaclean): Remove this when (if) ContentRulesRegistry code moves
+ // to extensions/browser/api.
+ virtual scoped_refptr<RulesRegistry> GetContentRulesRegistry(
+ content::BrowserContext* browser_context,
+ RulesCacheDelegate* cache_delegate) const;
+ virtual ContentRulesRegistry* ConvertToContentRulesRegistryPtr(
Ken Rockot(use gerrit already) 2014/09/19 22:56:09 I don't think this should be in ExtensionsAPIClien
+ RulesRegistry* rules_registry) const;
+
// NOTE: If this interface gains too many methods (perhaps more than 20) it
// should be split into one interface per API.
};
« no previous file with comments | « chrome/browser/extensions/api/declarative/rules_registry_service.cc ('k') | extensions/browser/api/extensions_api_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698