Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 590553002: gfx: Use SkMatrix44 helpers instead of accessing its bitflags. (Closed)

Created:
6 years, 3 months ago by danakj
Modified:
6 years, 3 months ago
Reviewers:
Ian Vollick
CC:
chromium-reviews, cc-bugs_chromium.org, Tom Hudson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gfx: Use SkMatrix44 helpers instead of accessing its bitflags. IsIdentityOrTranslation, IsScaleOrTranslation, and HasPerspective are now provided by SkMatrix44 so use those. R=vollick BUG=408710 Committed: https://crrev.com/670a4abf8d79ed3d4071aa1f5cf775cf77a75a94 Cr-Commit-Position: refs/heads/master@{#295766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M ui/gfx/transform.h View 3 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
danakj
6 years, 3 months ago (2014-09-19 18:29:27 UTC) #1
Ian Vollick
On 2014/09/19 18:29:27, danakj wrote: love it. lgtm.
6 years, 3 months ago (2014-09-19 19:07:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590553002/1
6 years, 3 months ago (2014-09-19 19:08:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as aced27d05d83d82c1f0c4d575ab7b1169b9cb206
6 years, 3 months ago (2014-09-19 19:38:36 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 19:39:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/670a4abf8d79ed3d4071aa1f5cf775cf77a75a94
Cr-Commit-Position: refs/heads/master@{#295766}

Powered by Google App Engine
This is Rietveld 408576698