Remove some dead BrowserPlugin and OOPIF compositing code.

Remove some dead BrowserPlugin and OOPIF compositing code.

BUG=330264
Committed: https://crrev.com/a135a78495712ed3da2d0c74685f7641348930cd
Cr-Commit-Position: refs/heads/master@{#295804}

[Fady Samuel, 2014-09-19 18:57:25]

fsamuel@chromium.org changed reviewers:
+ danakj@chromium.org

[Fady Samuel, 2014-09-19 18:57:26]

Hi Dana,

There's more work to do here but this is my first pass attempt at cleanup.
There's a lot of cruft accumulating in BrowserPlugin/OOPIF that I thought I'd
get rid of to make sense of it all.

Thanks,

Fady

[Charlie Reis, 2014-09-19 18:59:39]

creis@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2014-09-19 18:59:40]

[+site-isolation-reviews]

Just cc'ing our CL list, since this is of interest.  Always great to see dead
code going away!

[Charlie Reis, 2014-09-19 18:59:50]

creis@chromium.org changed reviewers:
- creis@chromium.org

[danakj, 2014-09-19 19:06:29]

https://codereview.chromium.org/590523003/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_impl.h (left):

https://codereview.chromium.org/590523003/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_impl.h:404: static void
AcknowledgeBufferPresent(
this looks a bit unrelated to this CL maybe split this one off?

https://codereview.chromium.org/590523003/diff/1/content/renderer/child_frame...
File content/renderer/child_frame_compositing_helper.cc (right):

https://codereview.chromium.org/590523003/diff/1/content/renderer/child_frame...
content/renderer/child_frame_compositing_helper.cc:211:
DCHECK(!texture_layer_.get());
can you remove texture_layer_?

[Fady Samuel, 2014-09-19 20:04:13]

PTAL

https://codereview.chromium.org/590523003/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_impl.h (left):

https://codereview.chromium.org/590523003/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_impl.h:404: static void
AcknowledgeBufferPresent(
On 2014/09/19 19:06:29, danakj wrote:
> this looks a bit unrelated to this CL maybe split this one off?

Done.

https://codereview.chromium.org/590523003/diff/1/content/renderer/child_frame...
File content/renderer/child_frame_compositing_helper.cc (right):

https://codereview.chromium.org/590523003/diff/1/content/renderer/child_frame...
content/renderer/child_frame_compositing_helper.cc:211:
DCHECK(!texture_layer_.get());
On 2014/09/19 19:06:29, danakj wrote:
> can you remove texture_layer_?

Done.

[danakj, 2014-09-19 20:27:54]

LGTM

[Fady Samuel, 2014-09-19 20:33:40]

fsamuel@chromium.org changed reviewers:
+ creis@chromium.org, kenrb@chromium.org

[Fady Samuel, 2014-09-19 20:33:41]

+creis@ for content OWNER
+kenrb@ for *_messages.h

[Charlie Reis, 2014-09-19 21:14:23]

Ken knows most of this better than me, so I'll defer to his review of the OOPIF
changes (not just the IPC changes).  Rubber stamp LGTM assuming it's dead code.

[kenrb, 2014-09-19 21:32:52]

emphatic lgtm

[Fady Samuel, 2014-09-19 21:35:38]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-09-19 21:37:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/590523003/30016

[commit-bot: I haz the power, 2014-09-19 22:49:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:49:09]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Fady Samuel, 2014-09-19 22:56:02]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2014-09-19 22:56:02]

The CQ bit was unchecked by fsamuel@chromium.org

[Fady Samuel, 2014-09-19 22:56:04]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2014-09-19 22:56:04]

The CQ bit was unchecked by fsamuel@chromium.org

[Fady Samuel, 2014-09-19 22:56:05]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2014-09-19 22:56:06]

The CQ bit was unchecked by fsamuel@chromium.org

[Fady Samuel, 2014-09-19 22:56:13]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:57:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/590523003/30016

[commit-bot: I haz the power, 2014-09-19 23:23:58]

Committed patchset #3 (id:30016) as 08520738d4542dcb46fc96bc4721b0f16b2449e0

[commit-bot: I haz the power, 2014-09-19 23:28:00]

Patchset 3 (id:??) landed as
https://crrev.com/a135a78495712ed3da2d0c74685f7641348930cd
Cr-Commit-Position: refs/heads/master@{#295804}