Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 590523002: Building both ia32 and x64 in the sdk build. (Closed)

Created:
6 years, 3 months ago by bradn
Modified:
6 years, 3 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Building both ia32 and x64 in the sdk build. We recently changed the chrome build so that nacl binaries of both 32 and 64 bit type are not built unless needed. The sdk had assumed both arches are built as a side effect. Building both arches in the sdk. BUG=None TEST=local R=binji@chromium.org Committed: https://crrev.com/96f42fb68643044639ededf55a48afb5747a46cb Cr-Commit-Position: refs/heads/master@{#296240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
bradn
6 years, 3 months ago (2014-09-19 20:03:36 UTC) #1
binji
lgtm
6 years, 3 months ago (2014-09-19 20:04:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590523002/1
6 years, 3 months ago (2014-09-19 20:26:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590523002/1
6 years, 3 months ago (2014-09-19 20:26:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11446)
6 years, 3 months ago (2014-09-19 21:23:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590523002/1
6 years, 3 months ago (2014-09-23 20:42:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6b39601ae492b31d51a3d00eca33cdeb5cc255b0
6 years, 3 months ago (2014-09-23 21:08:08 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 21:08:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96f42fb68643044639ededf55a48afb5747a46cb
Cr-Commit-Position: refs/heads/master@{#296240}

Powered by Google App Engine
This is Rietveld 408576698